Draft
Conversation
Pankraz76
commented
Nov 10, 2025
| * @param clazz the class to check; never {@code null} | ||
| * @return {@code true} if the class is {@code public} | ||
| * @see java.lang.reflect.Modifier#isPublic(int) | ||
| * @see Modifier#isPublic(int) |
Owner
Author
There was a problem hiding this comment.
only this unrelated change is quite impressive having a very modern codebase.
Changes have been made to junit-platform-commons/src/main/java/org/junit/platform/commons/support/ModifierSupport.java by:
org.openrewrite.java.migrate.UpgradeToJava17
org.openrewrite.java.migrate.RemovedModifierAndConstantBootstrapsConstructors
org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.lang.reflect.Modifier *(..), fullyQualifiedTargetTypeName=java.lang.reflect.Modifier}
Pankraz76
force-pushed
the
fix-gradle
branch
from
76d6a50 to
e5ce836
Compare
Pankraz76
commented
Nov 10, 2025
...ooling-support-tests/src/test/java/platform/tooling/support/tests/ModularUserGuideTests.java
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-gradle
branch
from
e5ce836 to
ff14a5c
Compare
Pankraz76
changed the title
StreamRulesRecipesStreamRulesRecipes
This was referenced Nov 10, 2025
vlsi
reviewed
Nov 10, 2025
Comment on lines
+13
to
+14
| apply(from = "gradle/rewrite.gradle") | ||
|
|
There was a problem hiding this comment.
Apply from is an anti-pattern, and JUnit bundles build plugins under https://github.com/Pankraz76/junit5/tree/main/gradle/plugins
Owner
Author
There was a problem hiding this comment.
Yes, thanks for the update. I can see where this is going, but I currently don’t have any idea how to fix it.
Can we handle this later, or could someone else please add it?
I’ve seen a similar approach from Elastic — it’s quite nice and straightforward, almost just a copy-and-paste calling the same API in the code configuration, like from a Gradle file.
Owner
Author
There was a problem hiding this comment.
imho this is not possible yet right? as the api does not offer rewrite, yet...
vlsi
reviewed
Nov 10, 2025
junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-gradle
branch
3 times, most recently
from
b6199e1 to
9ac0045
Compare
Changes have been made to junit-platform-commons/src/main/java/org/junit/platform/commons/support/ModifierSupport.java by:
org.openrewrite.java.migrate.UpgradeToJava17
org.openrewrite.java.migrate.RemovedModifierAndConstantBootstrapsConstructors
org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.lang.reflect.Modifier *(..), fullyQualifiedTargetTypeName=java.lang.reflect.Modifier}
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
fix-gradle
branch
from
9ac0045 to
0af17df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewritesupport forerrorprone.refasterrulesjunit-team/junit-framework#5002I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations